November 2014
-
General
Clean up the sound remapping stuff... remove the bits relating to sounds we haven't actually used anywhere in the source directly. DONT_BUILD.
-
General
Part 1 of attempting to adhere to C standard section 7.1.3. It turns out it's illegal to use identifiers that begin with _ or have __ anywhere in them. DONT_BUILD.
-
General
Get rid of -Wdeclaration-after-statement as we're only targeting C99 and C++ now. DONT_BUILD.
-
General
Mainly misc cleanups (and a fix for the C++ build), but there are a few important changes in here.
Show details
VM_OnEvent() has become VM_OnEvent(), VM_OnEventWithReturn(), VM_OnEventWithDist(), and VM_OnEventWithBoth() (the latter of which is only ever used once...). Of course, this required every call to VM_OnEvent() be changed. memberlabel_t and vmstate_t have been changed to use the regular "int" type versus explicitly specifying int32_t as they did previously. The rationale for this change is simply that it looks cleaner, and I think we should move toward just using "int" in most cases where there's no particular reason to specify an explicit data type. Also changes CON_KILLIT to just "return" instead of "continue". DONT_BUILD.
-
General
Inline krand() when not using KRANDDEBUG. DONT_BUILD.
-
General
Add FORCE_INLINE to compat.h and apply it to a couple of things we'd strongly prefer be inlined. DONT_BUILD.
-
General
Add my _clang-format file to the repository. These options are pretty close to what most of our code already looks like, the primary difference being that it enforces spaces between operators and operands. I was initially opposed to the spaces, but I would be lying if I said they didn't increase legibility of much of our code, in addition to making it a lot easier to identify the specific intent in cases where we have a lot of expressions nested within one another. DONT_BUILD.
-
General
Fix up conveyor belts. This fixes breakage of the movement in general, as well as corrects the general behavior of the effect so that a player on a moving surface is moved at a constant rate, regardless of whether the player crouches, is shrunk, etc. DONT_BUILD.
-
General
Fix Mapster32 fullscreen video modes. DONT_BUILD.
-
General
Fix minor menu bugs. DONT_BUILD.
-
General
Set up mouse cursor display in menus, with idle timeout fully implemented. No functionality yet. DONT_BUILD.
-
General
Fix C++ build. DONT_BUILD.
-
General
In release builds, #define Xaligned_alloc as xaligned_malloc.
Show details
Otherwise, the out-of-memory handler is not called in case of failure.
-
fix 'readgamearray' and 'resizearray' on Windows.
Show details
We must not use Xrealloc(), since gamearrays are now allocated with Xaligned_alloc(). NOTE: I did not check all potential problematic cases, only those to get LNGA3 up and running.
-
fix 'readgamearray' on 64-bit platforms.
Show details
Also prettify P_DisplaySpit().
-
General
a-c.c: don't USE_VECTOR_EXT with Clang, since it doesn't compile here.
-
player[].loogcnt, userdef[].color, minor fixes.
-
fix tilesizx[] and tilesizy[] system gamearrays.
-
General
Replace DOS box-drawing characters in the ASM with sane ASCII. DONT_BUILD.
-
some minor doc tweaks. DONT_BUILD.
-
General
Fix voxels in classic -- my error, confusing divscale() and mulscale() in r4576.
Show details
Optimizations are left to the reader :P. I would prefer to look for ways of giving the compilers hints about loops to unroll instead of having to read the resulting mess of manual unrolling, though.
-
General
gameexec.c: In VM_OnEvent_, don't form address like &sprite[-1].
Show details
The practical rationale: Clang-sanitize catches this, so this is bad. The real rationale: I *think* it is undefined behavior to even form such a pointer in C99. However, I would be hard pressed to provide a nice formal argument in terms of the Standard wording right now. It looks like 6.5.3.2#4 is to blame.
-
General
engine.c: prevent an oob read in drawsprite_classic() w/ floor-aligned sprites.
-
General
Fix oob write with stepping 'up' in the OSD history.
-
General
baselayer.c: fix an oob write to ylookup[] intoduced in r4695.
Show details
On Linux, it started manifesting itself since r4719 as crashes whose backtraces pointed to malloc() and were not helpful. Valgrind finally uncovered this.
-
General
Useless change I forgot. DONT_BUILD.
-
General
Sometimes I wonder why MSVC neglects to provide useful warnings. DONT_BUILD.
-
General
Minor tweaks to VM_OnEvent_(). DONT_BUILD.
-
General
Remove references to nonexistent enet_mmulti.h from Visual Studio project. DONT_BUILD.
-
General
Fix a handful of crash bugs I caused with the 32-bit ASM version of the classic renderer. DONT_BUILD.
-
General
Fix a crash I caused with MSVC in OSD_SetLogFile(). Apparently, the behavior of setvbuf() when passed a NULL ptr for a buffer is actually left up to the implementation regarding what it does with the size parameter... DONT_BUILD.
-
General
Clean up classic renderer header (a.h) a bit. DONT_BUILD.
-
General
A couple of additional compat.h formatting changes. DONT_BUILD.
-
General
clang-format a couple of pragma headers. DONT_BUILD.
-
General
LUT for slope recip calculations in classic. DONT_BUILD.
-
General
Fix a couple of Makefile errors Helixhorned noticed. DONT_BUILD.
-
General
menus.c: prevent using a null pointer as arg to "%s" format for sprintf().
Show details
DONT_BUILD.
-
General
Add forgotten events_defs.h, oops. DONT_BUILD.
-
fix building and startup up to tilesizx[] failure. DONT_BUILD.
Show details
- Needed to rip out enum GameEvent_t into own header file to prevent what would be a circular #include otherwise - Added some forgotten #ifdef LUNATIC - updated structure and function declarations on the Lua FFI side
-
fix possible crash when a CON error is raised due to access of invalid sprite.
Show details
For example, in CON_ERRPRINTF("invalid target sprite (%d) %d %d\n", iActor, vm.g_i, TrackerCast(vm.g_sp->picnum)); vm.g_i can be -1 and vm.g_sp can be NULL then. (Not anymore.) DONT_BUILD.
-
General
compat.h: pedantic whitespace formatting. DONT_BUILD.
-
General
Alter weapon switching to cycle through GROW_WEAPON when using next/previous weapon keys. DONT_BUILD.
-
General
Default map zoom to something a bit more useful on Android. DONT_BUILD.
-
General
CPLUSPLUS mode build fix. DONT_BUILD.
-
General
CPLUSPLUS mode by default in Makefile.common, C99 otherwise. DONT_BUILD.
-
General
Clean up some player code a bit... make bobposx/bobposy a vec2_t, make fricxv/fricyv a per-player vec2_t (TODO: CON access), promote angvel in input_t to int16_t and allow for player angle changes that result in odd numbered angles (we were effectively artificially limiting the angle to 1024 values before), fix some HUD model ID stuff that should help with the weapons in the HRP, clean up a bunch of random functions (P_FireWeapon(), P_DisplayTip(), P_DisplayAccess(), P_DisplayWeapon(), P_GetInput(), etc). Also clean up G_SetupFilenameBasedMusic() to loop through flac/ogg/mid when searching for usermap music replacements. Some of this really needs a BYTEVERSION bump, but these commits aren't for synthesis to build so we're not doing it yet. DONT_BUILD.
-
General
Try out __restrict in the classic renderer. #define'd for easy removal in case it causes problems or is useless.
-
General
Fix MSVC warning in Polymer
-
General
Inline yax_getbunches with old map format. DONT_BUILD.
-
General
More EDUKE32_PREDICT_FALSE, mostly in OSD_Printf(OSD_ERROR...) cases