EDuke32 Changelog Unofficial archive

Build 4184

28 November 2013 · 8 commits by 1 author · SVN

Builds by month 15 builds

Original log file · 20131128-4184.txt
------------------------------------------------------------------------
r4184 | helixhorned | 2013-11-28 13:18:11 -0800 (Thu, 28 Nov 2013) | 5 lines

Lunatic: document a couple of player members, especially some 'bool' ones.

Important because in Lua, a value of zero yields true in a boolean context.

BUILD_LUNATIC.
------------------------------------------------------------------------
r4183 | helixhorned | 2013-11-28 13:18:09 -0800 (Thu, 28 Nov 2013) | 1 line

multivoc.c: use a local variable instead of a file-scope one used locally.
------------------------------------------------------------------------
r4182 | helixhorned | 2013-11-28 13:18:07 -0800 (Thu, 28 Nov 2013) | 6 lines

a-c.c: Make vector extensions also be compiled with Clang.

I was checking for GCC >= 4.7, while Clangs pretends to be GCC 4.2. Use a
feature test macro instead. The comment I made in r4161 regarding GCC vs.
Clang code was wrong. Now, Clang generates slightly faster code for these cases
(solid and masked 4-pixel wide vlines).
------------------------------------------------------------------------
r4181 | helixhorned | 2013-11-28 13:18:05 -0800 (Thu, 28 Nov 2013) | 5 lines

In P_HandleSharedKeys(), clean up weapon index bound checking.

In particular, (int32_t)j != -1 is replaced by (uint32_t)j < MAX_WEAPONS
to prevent a value >= MAX_WEAPONS to be assigned to p->wantweaponfire (it's
used as a weapon index in P_CheckWeapon().
------------------------------------------------------------------------
r4180 | helixhorned | 2013-11-28 13:18:04 -0800 (Thu, 28 Nov 2013) | 5 lines

Don't assign result of A_PlaySound() to p->scream_voice if the former is >127.

Because p->scream_voice is an int8_t.
This is an unlikely situation (126 voices ought to be playing simultaneously
while starting the "scream" sound), but still...
------------------------------------------------------------------------
r4179 | helixhorned | 2013-11-28 13:18:02 -0800 (Thu, 28 Nov 2013) | 7 lines

LunaCON: disable some player members, tweak decls of others.

The ones disabled are because they were found to not be used in any mod I
tested. Exposing members directly is rarely good API.

- bool toggle_key_flag -> const uint8_t ... (because value 2 is used)
- make scream_voice, cheat_phase read-only
------------------------------------------------------------------------
r4178 | helixhorned | 2013-11-28 13:18:00 -0800 (Thu, 28 Nov 2013) | 1 line

Lunatic: slightly tweak the event/actor times printout when exiting.
------------------------------------------------------------------------
r4177 | helixhorned | 2013-11-28 13:17:56 -0800 (Thu, 28 Nov 2013) | 1 line

LunaCON: fix assignment to projectile sound/bsound/isound.
------------------------------------------------------------------------
See http://svn.eduke32.com/listing.php?repname=eduke32 for more details.

document a couple of player members, especially some 'bool' ones.

Philipp Kutin (Helixhorned) 28 Nov 2013, 13:18 UTC−8 r4184

Important because in Lua, a value of zero yields true in a boolean context. BUILD_LUNATIC.

Fix

a-c.c: Make vector extensions also be compiled with Clang.

Philipp Kutin (Helixhorned) 28 Nov 2013, 13:18 UTC−8 r4182

I was checking for GCC >= 4.7, while Clangs pretends to be GCC 4.2. Use a feature test macro instead. The comment I made in r4161 regarding GCC vs. Clang code was wrong. Now, Clang generates slightly faster code for these cases (solid and masked 4-pixel wide vlines).

In P_HandleSharedKeys(), clean up weapon index bound checking.

Philipp Kutin (Helixhorned) 28 Nov 2013, 13:18 UTC−8 r4181

In particular, (int32_t)j != -1 is replaced by (uint32_t)j < MAX_WEAPONS to prevent a value >= MAX_WEAPONS to be assigned to p->wantweaponfire (it's used as a weapon index in P_CheckWeapon().

Don't assign result of A_PlaySound() to p->scream_voice if the former is >127.

Philipp Kutin (Helixhorned) 28 Nov 2013, 13:18 UTC−8 r4180

Because p->scream_voice is an int8_t. This is an unlikely situation (126 voices ought to be playing simultaneously while starting the "scream" sound), but still...

Lunatic CON

disable some player members, tweak decls of others.

Philipp Kutin (Helixhorned) 28 Nov 2013, 13:18 UTC−8 r4179

The ones disabled are because they were found to not be used in any mod I tested. Exposing members directly is rarely good API. - bool toggle_key_flag -> const uint8_t ... (because value 2 is used) - make scream_voice, cheat_phase read-only