EDuke32 Changelog Unofficial archive

Build 2235

5 January 2012 · 3 commits by 1 author · SVN

Builds by month 318 builds

  1. Jan

  2. Feb

  3. Mar

  4. Apr

  5. May

  6. Jun

  7. Jul

  8. Aug

  9. Sep

  10. Oct

  11. Nov

  12. Dec

Original log file · 20120105-2235.txt 
------------------------------------------------------------------------
r2235 | helixhorned | 2012-01-05 12:48:37 -0800 (Thu, 05 Jan 2012) | 14 lines

When loading a game, DON'T restore 'adult' TV tiles. This fixes the recent
crashes.

Usually, after loading a game, some wall tiles are tweaked depending on whether
adult mode is enabled or not.  If it's not, those wall picnums are replaced
with blank or broken screens.  If it is, they are restored from the wall's
.extra member.  Apparently though, Mapster32 leaves some .extra members
floating around even after deleting a TROR nextwall link (it's used as the
'lower wall index').  Because MAXWALLS is greater than MAXTILES, this may
produce out-of-bounds accesses and corrupt memory (besides setting wall
tilenums to nonsensical values) later in the game.

Other than that, the change only affects loading savegames created with adult
mode OFF. Kinky TV screenies simply won't be restored then.
------------------------------------------------------------------------
r2234 | helixhorned | 2012-01-05 12:48:20 -0800 (Thu, 05 Jan 2012) | 1 line

savegame.c: some const void **ptr -> void **ptr, since they're certainly not const
------------------------------------------------------------------------
r2233 | helixhorned | 2012-01-05 12:48:05 -0800 (Thu, 05 Jan 2012) | 2 lines

trivial tweaks: some NULLing pointer after freeing them; move the 'too much mirrors'
check one 'if' down since mirrors are only created when the condition holds
------------------------------------------------------------------------
r2232 | helixhorned | 2012-01-03 11:56:10 -0800 (Tue, 03 Jan 2012) | 1 line

Pass bit 16 to P_SetGamePalette from CON's setgamepalette (forgotten from earlier commit)
------------------------------------------------------------------------
FixEngine

When loading a game, DON'T restore 'adult' TV tiles. This fixes the recent

Philipp Kutin (Helixhorned) 5 Jan 2012, 12:48 UTC−8 r2235

crashes. Usually, after loading a game, some wall tiles are tweaked depending on whether adult mode is enabled or not. If it's not, those wall picnums are replaced with blank or broken screens. If it is, they are restored from the wall's .extra member. Apparently though, Mapster32 leaves some .extra members floating around even after deleting a TROR nextwall link (it's used as the 'lower wall index'). Because MAXWALLS is greater than MAXTILES, this may produce out-of-bounds accesses and corrupt memory (besides setting wall tilenums to nonsensical values) later in the game. Other than that, the change only affects loading savegames created with adult mode OFF. Kinky TV screenies simply won't be restored then.

trivial tweaks: some NULLing pointer after freeing them; move the 'too much mirrors'

Philipp Kutin (Helixhorned) 5 Jan 2012, 12:48 UTC−8 r2233

check one 'if' down since mirrors are only created when the condition holds