File di log originale · 20111209-2172.txt
------------------------------------------------------------------------ r2172 | helixhorned | 2011-12-09 11:12:15 -0800 (Fri, 09 Dec 2011) | 1 line Fix negative array access in premap.c ------------------------------------------------------------------------ r2171 | helixhorned | 2011-12-09 11:12:01 -0800 (Fri, 09 Dec 2011) | 2 lines Fix potential out-of-bounds array access in P_DisplayTip (happened with WGR2 SVN, so not sure where there's a tipping animation there). ------------------------------------------------------------------------ r2170 | helixhorned | 2011-12-09 11:11:47 -0800 (Fri, 09 Dec 2011) | 6 lines Fix sintable[] access with out-of-bounds values in core engine functions (getzrange, hitscan, clipmove, drawmapview). They're reproducible with DNE1.3D; Since these angle values most likely come from CON code, my suggestion would be to bit-and all values representing angles with 2047 when setting the from CON, but I'd have to think about potential side-effects of doing this. ------------------------------------------------------------------------ r2169 | helixhorned | 2011-12-09 11:11:31 -0800 (Fri, 09 Dec 2011) | 7 lines - Fix invalid polymer light array access originating from game's cleanup callback 'G_Polymer_UnInit'. - In astub.c, reset spritelightid to -1 when nulling the spritelightptr of a sprite (no crashes observed, just precaution) - In sdlayer.c, catch SIGILLs with our signal handler too, since illegal instructions are what the instrumented debug builds will execute when attempting to carry out an undefined (per C) operation. ------------------------------------------------------------------------ r2168 | helixhorned | 2011-12-09 11:11:08 -0800 (Fri, 09 Dec 2011) | 1 line engine.c: fix shift by negative value in parascan(). ------------------------------------------------------------------------ r2167 | helixhorned | 2011-12-09 11:10:51 -0800 (Fri, 09 Dec 2011) | 1 line polymer.c: fix out-of-bounds picanm[] read. ------------------------------------------------------------------------ r2166 | helixhorned | 2011-12-09 11:10:35 -0800 (Fri, 09 Dec 2011) | 2 lines gameexec.c: fix calculation of a pointer value outside the bounds of an array and an invalid derived pointer value. ------------------------------------------------------------------------ r2165 | helixhorned | 2011-12-09 11:10:21 -0800 (Fri, 09 Dec 2011) | 1 line Fix shift by values greater than 31 in some voxel loading code. ------------------------------------------------------------------------ r2164 | helixhorned | 2011-12-09 11:10:03 -0800 (Fri, 09 Dec 2011) | 2 lines kplib.c: patch up negative array access, dunno how to really fix this at the root. ------------------------------------------------------------------------ r2163 | helixhorned | 2011-12-09 11:09:45 -0800 (Fri, 09 Dec 2011) | 3 lines Mapster32: fix AWFUL out-of-bounds WRITE with sector highlighting. How in the name of hell this could pass undetected for so long is a mystery to me. ------------------------------------------------------------------------ r2162 | helixhorned | 2011-12-09 11:09:29 -0800 (Fri, 09 Dec 2011) | 3 lines polymost_printext256: fix oob read when passing negative 'col' or 'backcol' values; check the color index that is potentially gotten from the string to be printed. ------------------------------------------------------------------------ r2161 | helixhorned | 2011-12-09 11:09:14 -0800 (Fri, 09 Dec 2011) | 2 lines Fix a potential out-of-bounds read and write when loading the help file in Mapster32. ------------------------------------------------------------------------ r2160 | helixhorned | 2011-12-09 11:09:00 -0800 (Fri, 09 Dec 2011) | 1 line When compiling debugging builds with clang, enable -fcatch-undefined-behavior. ------------------------------------------------------------------------ r2159 | helixhorned | 2011-12-09 11:08:47 -0800 (Fri, 09 Dec 2011) | 2 lines Makefiles: disable a few warning categories and other switches when compiling with clang to prevent spamming the output. ------------------------------------------------------------------------ r2158 | helixhorned | 2011-12-09 11:08:29 -0800 (Fri, 09 Dec 2011) | 1 line Remove some warnings with clang, code-side changes. ------------------------------------------------------------------------ r2157 | helixhorned | 2011-12-09 11:08:05 -0800 (Fri, 09 Dec 2011) | 1 line Fix a warning with 64-bit builds. ------------------------------------------------------------------------ r2156 | terminx | 2011-12-07 19:56:38 -0800 (Wed, 07 Dec 2011) | 2 lines Simple one-liner from Robin Green to fix a problem where the menu background tint would sometimes draw over the menu contents ------------------------------------------------------------------------
Fix potential out-of-bounds array access in P_DisplayTip (happened with
WGR2 SVN, so not sure where there's a tipping animation there).
Fix sintable[] access with out-of-bounds values in core engine functions
(getzrange, hitscan, clipmove, drawmapview). They're reproducible with DNE1.3D; Since these angle values most likely come from CON code, my suggestion would be to bit-and all values representing angles with 2047 when setting the from CON, but I'd have to think about potential side-effects of doing this.
- Fix invalid polymer light array access originating from game's cleanup
callback 'G_Polymer_UnInit'. - In astub.c, reset spritelightid to -1 when nulling the spritelightptr of a sprite (no crashes observed, just precaution) - In sdlayer.c, catch SIGILLs with our signal handler too, since illegal instructions are what the instrumented debug builds will execute when attempting to carry out an undefined (per C) operation.
engine.c: fix shift by negative value in parascan().
polymer.c: fix out-of-bounds picanm[] read.
gameexec.c: fix calculation of a pointer value outside the bounds of an array
and an invalid derived pointer value.
Fix shift by values greater than 31 in some voxel loading code.
kplib.c: patch up negative array access, dunno how to really fix this at
the root.
fix AWFUL out-of-bounds WRITE with sector highlighting.
How in the name of hell this could pass undetected for so long is a mystery to me.
fix oob read when passing negative 'col' or 'backcol'
values; check the color index that is potentially gotten from the string to be printed.
Fix a potential out-of-bounds read and write when loading the help file
in Mapster32.
When compiling debugging builds with clang, enable -fcatch-undefined-behavior.
disable a few warning categories and other switches when compiling
with clang to prevent spamming the output.
Remove some warnings with clang, code-side changes.
Fix a warning with 64-bit builds.
Già presente nella build 2156