What changed in EDuke32, build by build

Slight cleanup to MV_GetVorbisCommentLoops(). The biggest change here is swapping calls to atol to our Batol macro, which is actually backed by strtol instead of atol.

Hendricks and I discussed "auto *" and we've come to the conclusion that it's bad form, so this corrects that.

Reduce vorbis read block size from 32k to MV_MIXBUFFERSIZE. Despite requiring more calls into libvorbis, this should be faster on slower CPUs in cases where more copies of the same .ogg sound are attempting to be played at once than are allowed, e.g large explosion scenes in Ion Maiden.

I don't see a reason for these operations to be separated

Fix function that some sadist formatted with 3 spaces

macOS build fix

Fix oversight with wall texture rotation on tile 0

Fix issue with a couple symbols from cmdline.h sometimes picking up different linkage due to accidental double definition in game.h

CON syntax extension: the empty "[]" shortcut for accessing a struct at index THISACTOR can now be omitted.

Add unsigned access to actor .htmovflag through actor .htumovflag

Misc CON fixups

Further clean up C_SetScriptSize(). This also fixes a bug in the function where when expanding the buffer size, most of the extra space was left uninitialized due to bad parameters passed to memset().

Clean up A_InsertSprite() and the beginning of A_Spawn()

Sorting and formatting for [names|sound]dyn.[cpp|h]

Cleanup includes

SDL 2.0.9

Use references in G_UpdatePlayerFromMenu() and G_BackToMenu() for readability

This does nothing but fix indentation of a single block of code

Remove some effectively dead code that handled loading from duke3d.cfg if eduke32.cfg was not found. This has been useless for about a decade.

Drop C++ standard used in Visual Studio builds from C++17 to C++14, to be more consistent with our GNU makefile.

Move CONTROL_ProcessBinds() call to P_GetInput()

Fix usages of tab characters that slipped into menus.h at some point, and fix declaration of function Menu_Change() to match its definition

Very (very) slightly less terrible G_CheckPlayerColor() function.

Additional const and constexpr usage in compat.h and pragmas

Remove redundant statements. This commit doesn't actually do anything.

P_UpdateScreenPal() seems to belong here instead

Increase size of text buffer used for editor 3d mode info display--it was possible to overflow it

Prevent g_sounds[] buffer overflow when attempting to define a sound with an index higher than MAXSOUNDS-1. This reduces the number of sound definitions available by 1 as the last slot is now reserved for the error condition.

Remove redundant assignment and null ptr check

Replace error condition in rejectQueue_remove() with an assertion, because the NULL pointer it would return if something was fucked up would be unconditionally dereferenced in kdtree_add().

Static analyzer says this condition is never true

Revert r7017. I misread the code mismeasured the result.

Clean up error handling in shitty G_GetVersionFromWebsite() function

Add missing ifdef guards to namesdyn.h

Remove dead code branch from RECON (logic oversight) and get rid of a useless fallthrough__

Fix off-by-one error in currently not very useful dedicated server text console input

Useless yet innocuous sdlayer fixes

Use a local variable in SDL_GL_ATTRIBUTES macro instead of relying on it being declared in the function calling the macro

Fix MV_GetNextWAVBlock() to no longer check if the unsigned BlockLength value is less than 0.

Move SE40 floor/ceilingstat and Z coordinate backups to global variables instead of allocating them on the stack.

Fix potential null pointer dereferences when rendering a model with no animations (?)

Fix potential null pointer dereference

Fix a couple of things with the dreaded crosshair coloration functions. ;)

Trying to silence a warning at link time in VS. DONT_BUILD.

https://imgur.com/N2v8kjU

"@Dick can you make it so that its impossible to pan the floor texture in 2d mode if the texture isnt visible?"

Actually fix savegame crash... probably.

Fix embarrassing Windows-centric fuckup

VS project properties

Fix VS warning

Fix savegame crash issue

Minor fixups needed to build as a native VS project

Revise r6974

Fix parameter aliasing warning in G_LoadGroups()

Replace a bunch of fall-through comments with our fallthrough__ macro.

Disable a few more hard-coded sounds in EDUKE32_STANDALONE builds

Add PROJECTILE_RPG_IMPACT_DAMAGE flag for projectiles, 0x00400000. This makes PROJECTILE_RPG_IMPACT function more or less how it did prior to late 2016 when an issue involving the damage was identified and fixed, and moves the damage to the new flag.

Don't invalidate saves based on the compiled script CRC if the script hasn't been compiled yet

Xmalloc() -> Xrealloc() in C_AllocProjectile()

Apply the same autoaim Z position offsetting logic used on GREENSLIME and ROTATEGUN to any sprite with CSTAT_SPRITE_YCENTER set

Silence less stupid fucking warning

Silence stupid fucking warnings

Bump BYTEVERSION

Don't play DUKE_GOTHEALTHATLOW sound in standalone builds

Work around strange internal compiler error with gcc 8.2.0...

echo successful script commands invoked from the console with "do" back to the console in green to indicate success.

"Lomont then searched for a constant optimal even after one and two Newton iterations and found 0x5F375A86, which is more accurate than the original at every iteration stage."