June 2012
-
do strtok on a duplicated string containing the address in Net_Connect().
Show details
Also, - don't strip const when passing the char ptr to it and a couple more instances in game.c - use g_netPort when -connect parameter doesn't have a port suffix (":XXXX"), so that e.g. eduke32 -port 1700 -connect localhost is the same as eduke32 -connect localhost:1700 (-port must come before -connect, unfortunately.)
-
second part of buffer overflow check correction.
Show details
This was supposed to go into the last commit, but I did git commit --amend without adding the changes to the index. Now I'm too lazy to sort things out.
-
correct packet buffer overflow checks.
Show details
The GAMESTATE one has to be carried out twice, first on the data from xd3_encode_memory, and then with the compressed data (because it might have increased in size, though this is very unlikely). The MOVE check is similar, though there, failure of the first check implies corrupt memory (which is why we're Bassert'ing that condition). Currently, the overflow on GAMESTATE sending happens when switching to a different map.
-
remove (char *) casts where they amount to no-ops.
-
eliminate ptr->byte idx conversion of action/move/ai in t_data.
Show details
These are element indices for a while now. Also eliminate some dead code afterwards.