Revision r7186
Cleanup includes
Browse logs with clarity: filter by type/year, search text, and inspect parsed commit details.
Cleanup includes
SDL 2.0.9
Use references in G_UpdatePlayerFromMenu() and G_BackToMenu() for readability
This does nothing but fix indentation of a single block of code
Remove dead code that once opened a browser to the store page for Duke Nukem 3D: Megaton Edition on Steam
More control/input cleanup
Clean up some of the remaining stuff in duke3d/src/config.cpp a bit. Not very meaningful changes... just things I saw when trying to decide how to tackle some of this mess.
Remove the "ConsoleKeys[]" array from osdcmds.cpp in favor of accessing mact's sctokeylut[]
Move sctokeylut[] in mact to keyboard.h from keyboard.cpp
Remove several unused player struct members and bump BYTEVERSION
Split some of the title screen display stuff into separate functions
More premap cleanup
This is starting to feel like distilling diarrhea into grey water
Add the formats supported by libxmp-lite to the list of extensions to check for in G_SetupFilenameBasedMusic()
Introduce some more meaningful function names and structure to the code touched in the last commit
Clean up some of the level initialization and player value reset functions that live in premap.cpp
Derp
CON structure member access readability cleanup
Replace A_ResetVars() with a simpler version and tweak GAMEVAR_Q16PTR handling in VM_GAMEVAR_OPERATOR macro. The other couple things aren't functional changes at all.
This is supposed to fix some errors with HIGH_PRECISION_SPRITE reported by a static analyzer, wherein 32-bit values were shifted and truncated as 32-bit before being widened to a 64-bit type, which didn't seem like the intended behavior. This is the commit to look at if anything is suddenly fucked up in the classic software renderer.
Fix a couple of issues that cropped up after some of the previous OSD refactoring commits
OSD warning fix
The most minor of minor changes
Set XMP_PLAYER_INTERP to XMP_INTERP_SPLINE as it seems to sound better than the default setting
Fix a null pointer dereference in G_GameExit() so we don't crash while we're crashing
This bounds check is useless
Use auto in ldist() and dist() because it looks nicer than vec3_t const *const
Move g_defaultVideoModes[] and g_keyAsciiTable[] from baselayer.cpp to baselayer.h and make them constexpr
Just cleaning up a dump(er)
Use tabledivide64() in Gv_GetArrayCountFromFile()
Same shit, different diff
Another bunch of non-functional cleanup changes to the OSD
"using osdcmdptr_t = osdfuncparm_t const * const" because I'm tired of seeing it everywhere
More incremental improvements to horrible decade-old OSD code
Fix up osdfunc_exec()
Reduced buffer size used for scanning GRPs to display in the startup window from 8MB to 64K, in line with the previous commit that changed osdfunc_fileinfo(). I benchmarked this several times and could not find a case in which the 8MB buffer was faster.
Rework osdfunc_fileinfo()
Use "int" for OSD command return values and a few trivial globals. Our current usage of the return values would have even worked with bool, but we might want to add error conditions or something later.
Rename a couple of things in osd.cpp. There should be no change to functionality.
Small cleanups to OSD and game keybinding code before larger changes. Everything still works at this point.
Move pow2char and pow2long to build.h and make them constexpr
Rename the implementation of _lrotl() found at the top of kplib.cpp to klrotl() and use it unconditionally on platforms other than Win32 (it's only used in .bmp rendering).
Improve P_GetInput() a little
Improve OSD_Dispatch() a little
Improve CONTROL_GetMouseDelta()
------------------------------------------------------------------------ r7187 | terminx | 2018-11-18 10:09:58 -0800 (Sun, 18 Nov 2018) | 1 line Sorting and formatting for [names|sound]dyn.[cpp|h] ------------------------------------------------------------------------ r7186 | terminx | 2018-11-18 10:09:48 -0800 (Sun, 18 Nov 2018) | 1 line Cleanup includes ------------------------------------------------------------------------ r7185 | terminx | 2018-11-18 10:09:27 -0800 (Sun, 18 Nov 2018) | 1 line SDL 2.0.9 ------------------------------------------------------------------------ r7184 | terminx | 2018-11-18 10:09:09 -0800 (Sun, 18 Nov 2018) | 1 line Use references in G_UpdatePlayerFromMenu() and G_BackToMenu() for readability ------------------------------------------------------------------------ r7183 | terminx | 2018-11-18 10:09:04 -0800 (Sun, 18 Nov 2018) | 1 line This does nothing but fix indentation of a single block of code ------------------------------------------------------------------------ r7182 | terminx | 2018-11-18 10:08:59 -0800 (Sun, 18 Nov 2018) | 1 line Remove dead code that once opened a browser to the store page for Duke Nukem 3D: Megaton Edition on Steam ------------------------------------------------------------------------ r7181 | terminx | 2018-11-18 10:08:53 -0800 (Sun, 18 Nov 2018) | 1 line More control/input cleanup ------------------------------------------------------------------------ r7180 | terminx | 2018-11-18 10:08:44 -0800 (Sun, 18 Nov 2018) | 1 line Clean up some of the remaining stuff in duke3d/src/config.cpp a bit. Not very meaningful changes... just things I saw when trying to decide how to tackle some of this mess. ------------------------------------------------------------------------ r7179 | terminx | 2018-11-18 10:08:38 -0800 (Sun, 18 Nov 2018) | 1 line Remove the "ConsoleKeys[]" array from osdcmds.cpp in favor of accessing mact's sctokeylut[] ------------------------------------------------------------------------ r7178 | terminx | 2018-11-18 10:08:32 -0800 (Sun, 18 Nov 2018) | 1 line Move sctokeylut[] in mact to keyboard.h from keyboard.cpp ------------------------------------------------------------------------ r7177 | terminx | 2018-11-18 10:08:26 -0800 (Sun, 18 Nov 2018) | 1 line Remove several unused player struct members and bump BYTEVERSION ------------------------------------------------------------------------ r7176 | terminx | 2018-11-18 10:08:20 -0800 (Sun, 18 Nov 2018) | 1 line Split some of the title screen display stuff into separate functions ------------------------------------------------------------------------ r7175 | terminx | 2018-11-18 10:08:14 -0800 (Sun, 18 Nov 2018) | 1 line More premap cleanup ------------------------------------------------------------------------ r7174 | terminx | 2018-11-18 10:08:08 -0800 (Sun, 18 Nov 2018) | 1 line This is starting to feel like distilling diarrhea into grey water ------------------------------------------------------------------------ r7173 | terminx | 2018-11-18 10:08:02 -0800 (Sun, 18 Nov 2018) | 1 line Add the formats supported by libxmp-lite to the list of extensions to check for in G_SetupFilenameBasedMusic() ------------------------------------------------------------------------ r7172 | terminx | 2018-11-18 10:07:57 -0800 (Sun, 18 Nov 2018) | 1 line Introduce some more meaningful function names and structure to the code touched in the last commit ------------------------------------------------------------------------ r7171 | terminx | 2018-11-18 10:07:51 -0800 (Sun, 18 Nov 2018) | 1 line Clean up some of the level initialization and player value reset functions that live in premap.cpp ------------------------------------------------------------------------ r7170 | terminx | 2018-11-18 10:07:44 -0800 (Sun, 18 Nov 2018) | 1 line Derp ------------------------------------------------------------------------ r7169 | terminx | 2018-11-18 10:07:38 -0800 (Sun, 18 Nov 2018) | 1 line CON structure member access readability cleanup ------------------------------------------------------------------------ r7168 | terminx | 2018-11-18 10:07:30 -0800 (Sun, 18 Nov 2018) | 1 line Replace A_ResetVars() with a simpler version and tweak GAMEVAR_Q16PTR handling in VM_GAMEVAR_OPERATOR macro. The other couple things aren't functional changes at all. ------------------------------------------------------------------------ r7167 | terminx | 2018-11-18 10:07:25 -0800 (Sun, 18 Nov 2018) | 1 line This is supposed to fix some errors with HIGH_PRECISION_SPRITE reported by a static analyzer, wherein 32-bit values were shifted and truncated as 32-bit before being widened to a 64-bit type, which didn't seem like the intended behavior. This is the commit to look at if anything is suddenly fucked up in the classic software renderer. ------------------------------------------------------------------------ r7166 | terminx | 2018-11-18 10:07:20 -0800 (Sun, 18 Nov 2018) | 1 line Fix a couple of issues that cropped up after some of the previous OSD refactoring commits ------------------------------------------------------------------------ r7165 | terminx | 2018-11-18 10:07:15 -0800 (Sun, 18 Nov 2018) | 1 line OSD warning fix ------------------------------------------------------------------------ r7164 | terminx | 2018-11-18 10:07:10 -0800 (Sun, 18 Nov 2018) | 1 line The most minor of minor changes ------------------------------------------------------------------------ r7163 | terminx | 2018-11-18 10:07:04 -0800 (Sun, 18 Nov 2018) | 1 line Set XMP_PLAYER_INTERP to XMP_INTERP_SPLINE as it seems to sound better than the default setting ------------------------------------------------------------------------ r7162 | terminx | 2018-11-18 10:06:58 -0800 (Sun, 18 Nov 2018) | 1 line Fix a null pointer dereference in G_GameExit() so we don't crash while we're crashing ------------------------------------------------------------------------ r7161 | terminx | 2018-11-18 10:06:53 -0800 (Sun, 18 Nov 2018) | 1 line This bounds check is useless ------------------------------------------------------------------------ r7160 | terminx | 2018-11-18 10:06:48 -0800 (Sun, 18 Nov 2018) | 1 line Use auto in ldist() and dist() because it looks nicer than vec3_t const *const ------------------------------------------------------------------------ r7159 | terminx | 2018-11-18 10:06:43 -0800 (Sun, 18 Nov 2018) | 1 line Move g_defaultVideoModes[] and g_keyAsciiTable[] from baselayer.cpp to baselayer.h and make them constexpr ------------------------------------------------------------------------ r7158 | terminx | 2018-11-18 10:06:38 -0800 (Sun, 18 Nov 2018) | 1 line Just cleaning up a dump(er) ------------------------------------------------------------------------ r7157 | terminx | 2018-11-18 10:06:33 -0800 (Sun, 18 Nov 2018) | 1 line Use tabledivide64() in Gv_GetArrayCountFromFile() ------------------------------------------------------------------------ r7156 | terminx | 2018-11-18 10:06:27 -0800 (Sun, 18 Nov 2018) | 1 line Same shit, different diff ------------------------------------------------------------------------ r7155 | terminx | 2018-11-18 10:06:21 -0800 (Sun, 18 Nov 2018) | 1 line Another bunch of non-functional cleanup changes to the OSD ------------------------------------------------------------------------ r7154 | terminx | 2018-11-18 10:06:15 -0800 (Sun, 18 Nov 2018) | 1 line "using osdcmdptr_t = osdfuncparm_t const * const" because I'm tired of seeing it everywhere ------------------------------------------------------------------------ r7153 | terminx | 2018-11-18 10:06:07 -0800 (Sun, 18 Nov 2018) | 1 line More incremental improvements to horrible decade-old OSD code ------------------------------------------------------------------------ r7152 | terminx | 2018-11-18 10:06:01 -0800 (Sun, 18 Nov 2018) | 1 line Fix up osdfunc_exec() ------------------------------------------------------------------------ r7151 | terminx | 2018-11-18 10:05:56 -0800 (Sun, 18 Nov 2018) | 1 line Reduced buffer size used for scanning GRPs to display in the startup window from 8MB to 64K, in line with the previous commit that changed osdfunc_fileinfo(). I benchmarked this several times and could not find a case in which the 8MB buffer was faster. ------------------------------------------------------------------------ r7150 | terminx | 2018-11-18 10:05:51 -0800 (Sun, 18 Nov 2018) | 1 line Rework osdfunc_fileinfo() ------------------------------------------------------------------------ r7149 | terminx | 2018-11-18 10:05:45 -0800 (Sun, 18 Nov 2018) | 1 line Use "int" for OSD command return values and a few trivial globals. Our current usage of the return values would have even worked with bool, but we might want to add error conditions or something later. ------------------------------------------------------------------------ r7148 | terminx | 2018-11-18 10:05:37 -0800 (Sun, 18 Nov 2018) | 1 line Rename a couple of things in osd.cpp. There should be no change to functionality. ------------------------------------------------------------------------ r7147 | terminx | 2018-11-18 10:05:32 -0800 (Sun, 18 Nov 2018) | 1 line Small cleanups to OSD and game keybinding code before larger changes. Everything still works at this point. ------------------------------------------------------------------------ r7146 | terminx | 2018-11-18 10:05:26 -0800 (Sun, 18 Nov 2018) | 1 line Move pow2char and pow2long to build.h and make them constexpr ------------------------------------------------------------------------ r7145 | terminx | 2018-11-18 10:05:20 -0800 (Sun, 18 Nov 2018) | 1 line Rename the implementation of _lrotl() found at the top of kplib.cpp to klrotl() and use it unconditionally on platforms other than Win32 (it's only used in .bmp rendering). ------------------------------------------------------------------------ r7144 | terminx | 2018-11-18 10:05:15 -0800 (Sun, 18 Nov 2018) | 1 line Improve P_GetInput() a little ------------------------------------------------------------------------ r7143 | terminx | 2018-11-18 10:05:10 -0800 (Sun, 18 Nov 2018) | 1 line Improve OSD_Dispatch() a little ------------------------------------------------------------------------ r7142 | terminx | 2018-11-18 10:05:03 -0800 (Sun, 18 Nov 2018) | 1 line Improve CONTROL_GetMouseDelta() ------------------------------------------------------------------------ See http://svn.eduke32.com/listing.php?repname=eduke32 for more details.