Build 7047

Original log file · 20181006-7047.txt

------------------------------------------------------------------------
r7047 | terminx | 2018-10-06 22:23:53 -0700 (Sat, 06 Oct 2018) | 1 line

Remove dead code branch from RECON (logic oversight) and get rid of a useless fallthrough__
------------------------------------------------------------------------
r7046 | terminx | 2018-10-06 22:23:48 -0700 (Sat, 06 Oct 2018) | 1 line

Fix off-by-one error in currently not very useful dedicated server text console input
------------------------------------------------------------------------
r7045 | terminx | 2018-10-06 22:23:44 -0700 (Sat, 06 Oct 2018) | 1 line

Useless yet innocuous sdlayer fixes
------------------------------------------------------------------------
r7044 | terminx | 2018-10-06 22:23:39 -0700 (Sat, 06 Oct 2018) | 1 line

Use a local variable in SDL_GL_ATTRIBUTES macro instead of relying on it being declared in the function calling the macro
------------------------------------------------------------------------
r7043 | terminx | 2018-10-06 22:23:34 -0700 (Sat, 06 Oct 2018) | 1 line

Fix MV_GetNextWAVBlock() to no longer check if the unsigned BlockLength value is less than 0.
------------------------------------------------------------------------
r7042 | terminx | 2018-10-06 22:23:29 -0700 (Sat, 06 Oct 2018) | 1 line

Correct some fuckery in inflineintersect()
------------------------------------------------------------------------
r7041 | terminx | 2018-10-06 22:23:25 -0700 (Sat, 06 Oct 2018) | 1 line

Further revise a couple of null pointer checks in Polymost
------------------------------------------------------------------------
r7040 | terminx | 2018-10-06 22:23:20 -0700 (Sat, 06 Oct 2018) | 1 line

OSD strtoken maintenance
------------------------------------------------------------------------
r7039 | terminx | 2018-10-06 22:23:15 -0700 (Sat, 06 Oct 2018) | 1 line

Remove nonexistent file lzwnew.h from VS project
------------------------------------------------------------------------
r7038 | terminx | 2018-10-06 22:23:10 -0700 (Sat, 06 Oct 2018) | 1 line

Variable scope reductions
------------------------------------------------------------------------
r7037 | terminx | 2018-10-06 22:23:05 -0700 (Sat, 06 Oct 2018) | 1 line

Fix some weirdness in osdcmd_setactorvar() and remove an unused counter var from osdcmd_map()
------------------------------------------------------------------------
r7036 | terminx | 2018-10-06 22:23:00 -0700 (Sat, 06 Oct 2018) | 1 line

Parentheses around ternary conditions so CppCheck will stfu
------------------------------------------------------------------------
r7035 | terminx | 2018-10-06 22:22:55 -0700 (Sat, 06 Oct 2018) | 1 line

Tweak gamevar struct shortcut error handling
------------------------------------------------------------------------
r7034 | terminx | 2018-10-06 22:22:51 -0700 (Sat, 06 Oct 2018) | 1 line

Remove unused g_skipKeywordCheck
------------------------------------------------------------------------
r7033 | terminx | 2018-10-06 22:22:46 -0700 (Sat, 06 Oct 2018) | 1 line

Fix off-by-one error in CON_DEFINESOUND and null pointer arithmetic in CON_CASE and CON_DEFAULT (!)
------------------------------------------------------------------------
r7032 | terminx | 2018-10-06 22:22:41 -0700 (Sat, 06 Oct 2018) | 1 line

Variable scope reduction. This commit is boring as fuck.
------------------------------------------------------------------------
r7031 | terminx | 2018-10-06 22:22:36 -0700 (Sat, 06 Oct 2018) | 1 line

Fix more possible null pointer dereferences in mdsprite
------------------------------------------------------------------------
r7030 | terminx | 2018-10-06 22:22:32 -0700 (Sat, 06 Oct 2018) | 1 line

Mostly useless const-ifying and minor variable scope reduction in cache1d
------------------------------------------------------------------------
r7029 | terminx | 2018-10-06 22:22:27 -0700 (Sat, 06 Oct 2018) | 1 line

Fix filename string bounds check in kzipopen()
------------------------------------------------------------------------
r7028 | terminx | 2018-10-06 22:22:22 -0700 (Sat, 06 Oct 2018) | 1 line

Fix leaked sockets when failing to check for updates
------------------------------------------------------------------------
r7027 | terminx | 2018-10-06 22:22:17 -0700 (Sat, 06 Oct 2018) | 1 line

Pass vec2_ts to get_screen_coords() by reference instead of by value
------------------------------------------------------------------------
r7026 | terminx | 2018-10-06 22:22:13 -0700 (Sat, 06 Oct 2018) | 1 line

Prevent OOB array access when EVENT_INVENTORYLEFT or EVENT_INVENTORYRIGHT returns a bad value
------------------------------------------------------------------------
r7025 | terminx | 2018-10-06 22:22:08 -0700 (Sat, 06 Oct 2018) | 1 line

Hoist strlen() outside loop in kzopen()
------------------------------------------------------------------------
r7024 | terminx | 2018-10-06 22:22:03 -0700 (Sat, 06 Oct 2018) | 1 line

Hoist strlen() outside loop in osdfunc_listsymbols()
------------------------------------------------------------------------
r7023 | terminx | 2018-10-06 22:21:58 -0700 (Sat, 06 Oct 2018) | 1 line

Fix potential OOB spriteext[] access when checking SPREXT_NOTMD to determine whether or not to render a sprite's model, if available
------------------------------------------------------------------------
r7022 | terminx | 2018-10-06 22:21:53 -0700 (Sat, 06 Oct 2018) | 1 line

Oh look, the first 3 arguments passed to parascan() are completely useless
------------------------------------------------------------------------
r7021 | terminx | 2018-10-06 22:21:49 -0700 (Sat, 06 Oct 2018) | 1 line

Silence warning about truncating the result of memcmp
------------------------------------------------------------------------
r7020 | terminx | 2018-10-06 22:21:43 -0700 (Sat, 06 Oct 2018) | 1 line

Tweak osdfunc_setrendermode() to report whether the classic renderer is the C or ASM version
------------------------------------------------------------------------
r7019 | terminx | 2018-10-06 22:21:39 -0700 (Sat, 06 Oct 2018) | 1 line

Fix null pointer deference when attempting to load a model with improper or missing skin definitions
------------------------------------------------------------------------
r7018 | terminx | 2018-10-06 22:21:34 -0700 (Sat, 06 Oct 2018) | 1 line

Untabify kplib.cpp
------------------------------------------------------------------------
r7017 | terminx | 2018-10-06 22:21:29 -0700 (Sat, 06 Oct 2018) | 1 line

Fix overcomputation in the classic renderer due to a bug caused by a previous optimization attempt
------------------------------------------------------------------------
r7016 | terminx | 2018-10-06 22:21:24 -0700 (Sat, 06 Oct 2018) | 1 line

Slightly reorganize Bdirent struct for efficiency. Despite being "Bdirent", this struct in no way matches the system provided dirent struct.
------------------------------------------------------------------------
r7015 | terminx | 2018-10-06 22:21:20 -0700 (Sat, 06 Oct 2018) | 1 line

Add debug_break() to the top of handle_memerr()
------------------------------------------------------------------------
r7014 | terminx | 2018-10-06 22:21:15 -0700 (Sat, 06 Oct 2018) | 1 line

Fix false positive buffer overflow report in PVS-Studio
------------------------------------------------------------------------
r7013 | terminx | 2018-10-06 22:21:10 -0700 (Sat, 06 Oct 2018) | 1 line

Fix types of vars passed into sscanf() for use as return values
------------------------------------------------------------------------
r7012 | terminx | 2018-10-06 22:21:06 -0700 (Sat, 06 Oct 2018) | 1 line

Fix issue in the C version of the classic renderer where someone had attempted to negate a bool
------------------------------------------------------------------------
r7011 | terminx | 2018-10-06 22:21:01 -0700 (Sat, 06 Oct 2018) | 1 line

Fix bad logic for kill counter in G_DisplayRest()
------------------------------------------------------------------------
r7010 | terminx | 2018-10-06 22:20:56 -0700 (Sat, 06 Oct 2018) | 1 line

Fix accidental double assignment of pPlayer->jetpack_on in P_ResetStatus()
------------------------------------------------------------------------
r7009 | terminx | 2018-10-06 22:20:52 -0700 (Sat, 06 Oct 2018) | 1 line

Untabify polymost.h
------------------------------------------------------------------------
r7008 | terminx | 2018-10-06 22:20:47 -0700 (Sat, 06 Oct 2018) | 1 line

Slightly increase efficiency of osd_findsymbol() (this is the slow one that has to handle partial matches)
------------------------------------------------------------------------
r7007 | terminx | 2018-10-06 22:20:42 -0700 (Sat, 06 Oct 2018) | 1 line

Comment out bad entry in SDL keycode translation table
------------------------------------------------------------------------
r7006 | terminx | 2018-10-06 22:20:37 -0700 (Sat, 06 Oct 2018) | 1 line

Replace APLAYER picnum check in A_ShootWithZvel() with null pointer check
------------------------------------------------------------------------
r7005 | terminx | 2018-10-06 22:20:33 -0700 (Sat, 06 Oct 2018) | 1 line

Replace spritenum check with ptr check in VM_ScriptInfo()
------------------------------------------------------------------------
r7004 | terminx | 2018-10-06 22:20:28 -0700 (Sat, 06 Oct 2018) | 1 line

Fix potential null pointer dereferencing
------------------------------------------------------------------------
r7003 | terminx | 2018-10-06 22:20:23 -0700 (Sat, 06 Oct 2018) | 1 line

Fix minor bug where a null pointer was passed into free() unconditionally
------------------------------------------------------------------------
r7002 | terminx | 2018-10-06 22:20:19 -0700 (Sat, 06 Oct 2018) | 1 line

Fix potential texcache issue with HICTINT_IN_MEMORY and HICTINT_APPLYOVERALTPAL due to a mistake involving operator precedence
------------------------------------------------------------------------
r7001 | terminx | 2018-10-06 22:20:14 -0700 (Sat, 06 Oct 2018) | 1 line

Fix potential uninitialized use of highlightx/y/1/2 in the editor and convert them to vec2_t in the process
------------------------------------------------------------------------
r7000 | terminx | 2018-10-06 22:20:09 -0700 (Sat, 06 Oct 2018) | 1 line

Fix potential dereference of null pointer when calling polymost_bindPth()
------------------------------------------------------------------------
r6999 | terminx | 2018-10-06 22:20:04 -0700 (Sat, 06 Oct 2018) | 1 line

Fix potential null pointer dereference in S_DefineAudioIfSupported() when passing filenames without extensions
------------------------------------------------------------------------
See http://svn.eduke32.com/listing.php?repname=eduke32 for more details.

Remove dead code branch from RECON (logic oversight) and get rid of a useless fallthrough__

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7047

Fix

Fix off-by-one error in currently not very useful dedicated server text console input

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7046

Fix

Useless yet innocuous sdlayer fixes

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7045

Use a local variable in SDL_GL_ATTRIBUTES macro instead of relying on it being declared in the function calling the macro

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7044

Fix

Fix MV_GetNextWAVBlock() to no longer check if the unsigned BlockLength value is less than 0.

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7043

Correct some fuckery in inflineintersect()

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7042

FixEngine

Further revise a couple of null pointer checks in Polymost

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7041

OSD strtoken maintenance

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7040

Remove nonexistent file lzwnew.h from VS project

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7039

Variable scope reductions

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7038

Fix

Fix some weirdness in osdcmd_setactorvar() and remove an unused counter var from osdcmd_map()

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7037

Parentheses around ternary conditions so CppCheck will stfu

Richard Gobeille (TerminX) 6 Oct 2018, 22:23 UTC−7 r7036

CON

Tweak gamevar struct shortcut error handling

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7035

Remove unused g_skipKeywordCheck

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7034

Fix

Fix off-by-one error in CON_DEFINESOUND and null pointer arithmetic in CON_CASE and CON_DEFAULT (!)

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7033

Variable scope reduction. This commit is boring as fuck.

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7032

Fix

Fix more possible null pointer dereferences in mdsprite

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7031

Mostly useless const-ifying and minor variable scope reduction in cache1d

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7030

Fix

Fix filename string bounds check in kzipopen()

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7029

Fix

Fix leaked sockets when failing to check for updates

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7028

Pass vec2_ts to get_screen_coords() by reference instead of by value

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7027

CON

Prevent OOB array access when EVENT_INVENTORYLEFT or EVENT_INVENTORYRIGHT returns a bad value

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7026

Hoist strlen() outside loop in kzopen()

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7025

Hoist strlen() outside loop in osdfunc_listsymbols()

Richard Gobeille (TerminX) 6 Oct 2018, 22:22 UTC−7 r7024

FixEngine

Fix potential OOB spriteext[] access when checking SPREXT_NOTMD to determine whether or not to render a sprite's model, if available

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7023

Oh look, the first 3 arguments passed to parascan() are completely useless

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7022

Silence warning about truncating the result of memcmp

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7021

Engine

Tweak osdfunc_setrendermode() to report whether the classic renderer is the C or ASM version

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7020

Fix

Fix null pointer deference when attempting to load a model with improper or missing skin definitions

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7019

Untabify kplib.cpp

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7018

FixEngine

Fix overcomputation in the classic renderer due to a bug caused by a previous optimization attempt

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7017

Slightly reorganize Bdirent struct for efficiency. Despite being "Bdirent", this struct in no way matches the system provided dirent struct.

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7016

Add debug_break() to the top of handle_memerr()

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7015

Fix

Fix false positive buffer overflow report in PVS-Studio

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7014

Fix

Fix types of vars passed into sscanf() for use as return values

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7013

FixEngine

Fix issue in the C version of the classic renderer where someone had attempted to negate a bool

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7012

Fix

Fix bad logic for kill counter in G_DisplayRest()

Richard Gobeille (TerminX) 6 Oct 2018, 22:21 UTC−7 r7011

Fix

Fix accidental double assignment of pPlayer->jetpack_on in P_ResetStatus()

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7010

Engine

Untabify polymost.h

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7009

Slightly increase efficiency of osd_findsymbol() (this is the slow one that has to handle partial matches)

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7008

Comment out bad entry in SDL keycode translation table

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7007

Fix

Replace APLAYER picnum check in A_ShootWithZvel() with null pointer check

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7006

Replace spritenum check with ptr check in VM_ScriptInfo()

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7005

Fix

Fix potential null pointer dereferencing

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7004

Fix

Fix minor bug where a null pointer was passed into free() unconditionally

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7003

Fix

Fix potential texcache issue with HICTINT_IN_MEMORY and HICTINT_APPLYOVERALTPAL due to a mistake involving operator precedence

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7002

Fix

Fix potential uninitialized use of highlightx/y/1/2 in the editor and convert them to vec2_t in the process

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7001

Fix

Fix potential dereference of null pointer when calling polymost_bindPth()

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r7000

Fix

Fix potential null pointer dereference in S_DefineAudioIfSupported() when passing filenames without extensions

Richard Gobeille (TerminX) 6 Oct 2018, 22:20 UTC−7 r6999

Builds by month 112 builds

Jan

Feb

Mar

Apr

May

Jun

Jul

Aug

Sep

Oct

Nov

Dec

Remove dead code branch from RECON (logic oversight) and get rid of a useless fallthrough__

Fix off-by-one error in currently not very useful dedicated server text console input

Useless yet innocuous sdlayer fixes

Use a local variable in SDL_GL_ATTRIBUTES macro instead of relying on it being declared in the function calling the macro

Fix MV_GetNextWAVBlock() to no longer check if the unsigned BlockLength value is less than 0.

Correct some fuckery in inflineintersect()

Further revise a couple of null pointer checks in Polymost

OSD strtoken maintenance

Remove nonexistent file lzwnew.h from VS project

Variable scope reductions

Fix some weirdness in osdcmd_setactorvar() and remove an unused counter var from osdcmd_map()

Parentheses around ternary conditions so CppCheck will stfu

Tweak gamevar struct shortcut error handling

Remove unused g_skipKeywordCheck

Fix off-by-one error in CON_DEFINESOUND and null pointer arithmetic in CON_CASE and CON_DEFAULT (!)

Variable scope reduction. This commit is boring as fuck.

Fix more possible null pointer dereferences in mdsprite

Mostly useless const-ifying and minor variable scope reduction in cache1d

Fix filename string bounds check in kzipopen()

Fix leaked sockets when failing to check for updates

Pass vec2_ts to get_screen_coords() by reference instead of by value

Prevent OOB array access when EVENT_INVENTORYLEFT or EVENT_INVENTORYRIGHT returns a bad value

Hoist strlen() outside loop in kzopen()

Hoist strlen() outside loop in osdfunc_listsymbols()

Fix potential OOB spriteext[] access when checking SPREXT_NOTMD to determine whether or not to render a sprite's model, if available

Oh look, the first 3 arguments passed to parascan() are completely useless

Silence warning about truncating the result of memcmp

Tweak osdfunc_setrendermode() to report whether the classic renderer is the C or ASM version

Fix null pointer deference when attempting to load a model with improper or missing skin definitions

Untabify kplib.cpp

Fix overcomputation in the classic renderer due to a bug caused by a previous optimization attempt

Slightly reorganize Bdirent struct for efficiency. Despite being "Bdirent", this struct in no way matches the system provided dirent struct.

Add debug_break() to the top of handle_memerr()

Fix false positive buffer overflow report in PVS-Studio

Fix types of vars passed into sscanf() for use as return values

Fix issue in the C version of the classic renderer where someone had attempted to negate a bool

Fix bad logic for kill counter in G_DisplayRest()

Fix accidental double assignment of pPlayer->jetpack_on in P_ResetStatus()

Untabify polymost.h

Slightly increase efficiency of osd_findsymbol() (this is the slow one that has to handle partial matches)

Comment out bad entry in SDL keycode translation table

Replace APLAYER picnum check in A_ShootWithZvel() with null pointer check

Replace spritenum check with ptr check in VM_ScriptInfo()

Fix potential null pointer dereferencing

Fix minor bug where a null pointer was passed into free() unconditionally

Fix potential texcache issue with HICTINT_IN_MEMORY and HICTINT_APPLYOVERALTPAL due to a mistake involving operator precedence

Fix potential uninitialized use of highlightx/y/1/2 in the editor and convert them to vec2_t in the process

Fix potential dereference of null pointer when calling polymost_bindPth()

Fix potential null pointer dereference in S_DefineAudioIfSupported() when passing filenames without extensions