allow access to sprite[].yvel through set_yvel() member, document.
BUILD_LUNATIC.
Original log file · 20131228-4230.txt
------------------------------------------------------------------------ r4230 | helixhorned | 2013-12-28 09:04:39 -0800 (Sat, 28 Dec 2013) | 3 lines Lunatic: allow access to sprite[].yvel through set_yvel() member, document. BUILD_LUNATIC. ------------------------------------------------------------------------ r4229 | helixhorned | 2013-12-28 09:04:36 -0800 (Sat, 28 Dec 2013) | 1 line Remaining sanitizing of .yvel usage plus minor cleanup. ------------------------------------------------------------------------ r4228 | helixhorned | 2013-12-28 09:04:34 -0800 (Sat, 28 Dec 2013) | 3 lines Clean up legacy ROR code and introduce LEGACY_ROR define in game.h. Also, bound-check two .yvel meant as sprite indices in actors.c. ------------------------------------------------------------------------ r4227 | helixhorned | 2013-12-28 09:04:31 -0800 (Sat, 28 Dec 2013) | 1 line Make a couple of player functions take player indices instead of DukePlayer_t *. ------------------------------------------------------------------------ r4226 | helixhorned | 2013-12-28 09:04:27 -0800 (Sat, 28 Dec 2013) | 10 lines Guard retrieval of player index (.yvel) from APLAYER sprite. It is unacceptable that yvel is on one hand modifiable without restriction from scripting, but can be used as an array index without prior bound check in the C code. Because that member has an overloaded meaning and is also used for innocuous purposes such as the green color intensity of an SE light, it's infeasible to restrict access from scripting. Consequently, we must add bound checks on the C side. This is the first part of the effort to make .yvel safe, adding two functions P_Get() and P_GetP(). There are a couple of other uses as some kind of index. ------------------------------------------------------------------------ r4225 | helixhorned | 2013-12-28 09:04:22 -0800 (Sat, 28 Dec 2013) | 1 line Reserve 16 tiles from the end of MAXTILES, don't allow as user tiles from ART/DEF. ------------------------------------------------------------------------ r4224 | helixhorned | 2013-12-28 09:04:18 -0800 (Sat, 28 Dec 2013) | 1 line Lunatic: add example toggling forcefield wall to test.lua. ------------------------------------------------------------------------ See http://svn.eduke32.com/listing.php?repname=eduke32 for more details.
Remaining sanitizing of .yvel usage plus minor cleanup.
Clean up legacy ROR code and introduce LEGACY_ROR define in game.h.
Also, bound-check two .yvel meant as sprite indices in actors.c.
Make a couple of player functions take player indices instead of DukePlayer_t *.
Guard retrieval of player index (.yvel) from APLAYER sprite.
It is unacceptable that yvel is on one hand modifiable without restriction from scripting, but can be used as an array index without prior bound check in the C code. Because that member has an overloaded meaning and is also used for innocuous purposes such as the green color intensity of an SE light, it's infeasible to restrict access from scripting. Consequently, we must add bound checks on the C side. This is the first part of the effort to make .yvel safe, adding two functions P_Get() and P_GetP(). There are a couple of other uses as some kind of index.