player.c: In G_DrawTileScaled, lose bit 1024 (prior to r1658, bit 256).
I checked all direct and transitive uses of that function and am fairly confident that it is never used.
File di log originale · 20120819-2930.txt
------------------------------------------------------------------------ r2930 | helixhorned | 2012-08-19 05:59:03 -0700 (Sun, 19 Aug 2012) | 4 lines player.c: In G_DrawTileScaled, lose bit 1024 (prior to r1658, bit 256). I checked all direct and transitive uses of that function and am fairly confident that it is never used. ------------------------------------------------------------------------ r2929 | helixhorned | 2012-08-19 05:57:57 -0700 (Sun, 19 Aug 2012) | 6 lines Introduce additional rotatesprite bit for internal use and mask ext. ones from CON. ROTATESPRITE_MAX is moved to build.h and all orientation bits from CON commands using rotatesprite are ANDed with (ROTATESPRITE_MAX-1). Some of the functions use ROTATESPRITE_MAX for different internal purposes, which will not be exposed to CON now (a good thing). Also, dorotspr_handle_bit2 is made clearer. ------------------------------------------------------------------------ r2928 | helixhorned | 2012-08-19 05:56:51 -0700 (Sun, 19 Aug 2012) | 6 lines Clean up a couple of rotatesprite uses. The black translucent background underneath the user map list will now be drawn with a shade 32 tile 0 instead of tile BLANK, since I've seen the latter being replaced in some mod. Also, it will look the same regardless of screen aspect. ------------------------------------------------------------------------ r2927 | helixhorned | 2012-08-19 05:55:45 -0700 (Sun, 19 Aug 2012) | 3 lines Restucture dorotspr_handle_bit2(). This also fixes the OSD with aspects < 4/3. I broke that, too. ------------------------------------------------------------------------ r2926 | helixhorned | 2012-08-19 05:55:35 -0700 (Sun, 19 Aug 2012) | 4 lines Always draw the full original status bar fully instead of in patches. It seems like I broke the blitty/patchy way of drawing it with one of the last commits. ------------------------------------------------------------------------ r2925 | helixhorned | 2012-08-19 05:54:30 -0700 (Sun, 19 Aug 2012) | 1 line Some g_netServer || g_netServer --> g_netServer. ------------------------------------------------------------------------ r2924 | helixhorned | 2012-08-19 05:53:24 -0700 (Sun, 19 Aug 2012) | 5 lines In places where fullscreen tiles are drawn (logo etc.), use clearallviews(). This really fixes clearing the borders to the left and right with widescreen and hud_bgstretch=0. Also, it seems to fix glitches when the "screen size" is small (ud.screen_size is large). ------------------------------------------------------------------------ r2923 | helixhorned | 2012-08-19 05:52:18 -0700 (Sun, 19 Aug 2012) | 1 line Lunatic: rotatesprite+test, player access, misc. ------------------------------------------------------------------------ r2922 | helixhorned | 2012-08-19 05:52:10 -0700 (Sun, 19 Aug 2012) | 1 line mdsprite.c: factor out two instances of identical code. ------------------------------------------------------------------------ r2921 | helixhorned | 2012-08-19 05:51:04 -0700 (Sun, 19 Aug 2012) | 5 lines Clean up handling of widescreen bits in dorotatesprite functions. Don't call setaspect from them, because the only thing that's needed is (in classic) yxaspect and xyaspect. Pass these from the helper function defined earlier instead. ------------------------------------------------------------------------ r2920 | helixhorned | 2012-08-19 05:50:42 -0700 (Sun, 19 Aug 2012) | 1 line player.c: fix a check of md_tilehasmodel return value against >0 (should be >=0) ------------------------------------------------------------------------ r2919 | helixhorned | 2012-08-19 05:49:37 -0700 (Sun, 19 Aug 2012) | 1 line Clean up polymost_dorotatesprite a little (triv. changes only) ------------------------------------------------------------------------ r2918 | helixhorned | 2012-08-19 05:48:31 -0700 (Sun, 19 Aug 2012) | 5 lines In polymost_dorotatesprite, don't set [xy]dimen to [xy]dim temporarily. This fixes stuff like the HUD chaingun with widescreen and small "screen sizes" (in-game viewport). It also makes rotatesprite behave more like classic overall. I have no idea why it was there in the first place. ------------------------------------------------------------------------ r2917 | helixhorned | 2012-08-19 05:47:55 -0700 (Sun, 19 Aug 2012) | 1 line Clean up player.c's weapon display code (no functional changes). ------------------------------------------------------------------------
Introduce additional rotatesprite bit for internal use and mask ext. ones from CON.
ROTATESPRITE_MAX is moved to build.h and all orientation bits from CON commands using rotatesprite are ANDed with (ROTATESPRITE_MAX-1). Some of the functions use ROTATESPRITE_MAX for different internal purposes, which will not be exposed to CON now (a good thing). Also, dorotspr_handle_bit2 is made clearer.
Clean up a couple of rotatesprite uses.
The black translucent background underneath the user map list will now be drawn with a shade 32 tile 0 instead of tile BLANK, since I've seen the latter being replaced in some mod. Also, it will look the same regardless of screen aspect.
Restucture dorotspr_handle_bit2().
This also fixes the OSD with aspects < 4/3. I broke that, too.
Always draw the full original status bar fully instead of in patches.
It seems like I broke the blitty/patchy way of drawing it with one of the last commits.
Some g_netServer || g_netServer --> g_netServer.
In places where fullscreen tiles are drawn (logo etc.), use clearallviews().
This really fixes clearing the borders to the left and right with widescreen and hud_bgstretch=0. Also, it seems to fix glitches when the "screen size" is small (ud.screen_size is large).
rotatesprite+test, player access, misc.
mdsprite.c: factor out two instances of identical code.
Clean up handling of widescreen bits in dorotatesprite functions.
Don't call setaspect from them, because the only thing that's needed is (in classic) yxaspect and xyaspect. Pass these from the helper function defined earlier instead.
player.c: fix a check of md_tilehasmodel return value against >0 (should be >=0)
Clean up polymost_dorotatesprite a little (triv. changes only)
In polymost_dorotatesprite, don't set [xy]dimen to [xy]dim temporarily.
This fixes stuff like the HUD chaingun with widescreen and small "screen sizes" (in-game viewport). It also makes rotatesprite behave more like classic overall. I have no idea why it was there in the first place.