Text-repl.: hitinfo variables -> hit, hit{sprite,sect,wall} members -> no "hit"
This makes the code rather more readable in some places. Unlike the two preceding commits, this one is actually purely textual replacement.
Original log file · 20120810-2877.txt
------------------------------------------------------------------------
r2877 | helixhorned | 2012-08-10 12:12:01 -0700 (Fri, 10 Aug 2012) | 4 lines
Text-repl.: hitinfo variables -> hit, hit{sprite,sect,wall} members -> no "hit"
This makes the code rather more readable in some places. Unlike the two
preceding commits, this one is actually purely textual replacement.
------------------------------------------------------------------------
r2876 | helixhorned | 2012-08-10 12:11:56 -0700 (Fri, 10 Aug 2012) | 7 lines
Mass text replacement g_player[p].ps --> ps, part 2 (harder)
Functions affected are G_Move* in actors.c and A_Shoot in player.c.
Here, the p variable had function scope, now it's redeclared in shorter
blocks. I'm still relatively sure that no observable behavior was changed,
though not as sure as in part 1. Also, some dead assignments and the like
are eliminated.
------------------------------------------------------------------------
r2875 | helixhorned | 2012-08-10 12:11:53 -0700 (Fri, 10 Aug 2012) | 4 lines
Mass text replacement g_player[p].ps --> ps, part 1 (the easy one).
The p variable (sometimes named differently) has short scope in all cases,
so I'm almost sure that the replacements amount to an identity transformation.
------------------------------------------------------------------------
r2874 | helixhorned | 2012-08-10 12:11:49 -0700 (Fri, 10 Aug 2012) | 1 line
actors.c: factor out 4 instances of id. code (up to args) into nudge_player().
------------------------------------------------------------------------
r2873 | helixhorned | 2012-08-10 12:11:47 -0700 (Fri, 10 Aug 2012) | 3 lines
CON: factor out addammo/addweapon{,var} common code, harden addweaponvar...
... against invalid weapon indices and arguments accessed from arrays/structs.
------------------------------------------------------------------------
r2872 | helixhorned | 2012-08-10 12:11:43 -0700 (Fri, 10 Aug 2012) | 1 line
Lunatic: rewrite bitar to use arrays of int32, more convenience ops.
------------------------------------------------------------------------
Mass text replacement g_player[p].ps --> ps, part 2 (harder)
Functions affected are G_Move* in actors.c and A_Shoot in player.c. Here, the p variable had function scope, now it's redeclared in shorter blocks. I'm still relatively sure that no observable behavior was changed, though not as sure as in part 1. Also, some dead assignments and the like are eliminated.
Mass text replacement g_player[p].ps --> ps, part 1 (the easy one).
The p variable (sometimes named differently) has short scope in all cases, so I'm almost sure that the replacements amount to an identity transformation.
actors.c: factor out 4 instances of id. code (up to args) into nudge_player().
factor out addammo/addweapon{,var} common code, harden addweaponvar...
... against invalid weapon indices and arguments accessed from arrays/structs.