3 June 2012 · 8 commits by 1 author · SVN
------------------------------------------------------------------------
r2737 | helixhorned | 2012-06-03 12:20:41 -0700 (Sun, 03 Jun 2012) | 11 lines
net: do strtok on a duplicated string containing the address in Net_Connect().
Also,
- don't strip const when passing the char ptr to it and a couple more
instances in game.c
- use g_netPort when -connect parameter doesn't have a port suffix (":XXXX"),
so that e.g.
eduke32 -port 1700 -connect localhost
is the same as
eduke32 -connect localhost:1700
(-port must come before -connect, unfortunately.)
------------------------------------------------------------------------
r2736 | helixhorned | 2012-06-03 12:20:39 -0700 (Sun, 03 Jun 2012) | 6 lines
net: second part of buffer overflow check correction.
This was supposed to go into the last commit, but I did
git commit --amend
without adding the changes to the index. Now I'm too lazy to sort
things out.
------------------------------------------------------------------------
r2735 | helixhorned | 2012-06-03 12:20:36 -0700 (Sun, 03 Jun 2012) | 10 lines
net: correct packet buffer overflow checks.
The GAMESTATE one has to be carried out twice, first on the data from
xd3_encode_memory, and then with the compressed data (because it might have
increased in size, though this is very unlikely). The MOVE check is
similar, though there, failure of the first check implies corrupt memory
(which is why we're Bassert'ing that condition).
Currently, the overflow on GAMESTATE sending happens when switching to a
different map.
------------------------------------------------------------------------
r2734 | helixhorned | 2012-06-03 12:20:34 -0700 (Sun, 03 Jun 2012) | 1 line
net: remove (char *) casts where they amount to no-ops.
------------------------------------------------------------------------
r2733 | helixhorned | 2012-06-03 12:20:32 -0700 (Sun, 03 Jun 2012) | 1 line
Fix a "set but not used warning" in xdelta3.c, revert definition of XD3_ASSERT.
------------------------------------------------------------------------
r2732 | helixhorned | 2012-06-03 12:20:29 -0700 (Sun, 03 Jun 2012) | 1 line
Revert a change in xdelta3.c done in r2683.
------------------------------------------------------------------------
r2731 | helixhorned | 2012-06-03 12:20:26 -0700 (Sun, 03 Jun 2012) | 4 lines
net: eliminate ptr->byte idx conversion of action/move/ai in t_data.
These are element indices for a while now. Also eliminate some dead
code afterwards.
------------------------------------------------------------------------
r2730 | helixhorned | 2012-06-03 12:20:23 -0700 (Sun, 03 Jun 2012) | 4 lines
Bump BYTEVERSION, correct actor_t size on x64, add assert(sizeof(actor_t)==128).
r2727 made old savegames incompatible, as an array with MAXVOLUMES*MAXLEVELS
is saved in Gv_WriteSave().
------------------------------------------------------------------------
Also, - don't strip const when passing the char ptr to it and a couple more instances in game.c - use g_netPort when -connect parameter doesn't have a port suffix (":XXXX"), so that e.g. eduke32 -port 1700 -connect localhost is the same as eduke32 -connect localhost:1700 (-port must come before -connect, unfortunately.)
This was supposed to go into the last commit, but I did git commit --amend without adding the changes to the index. Now I'm too lazy to sort things out.
The GAMESTATE one has to be carried out twice, first on the data from xd3_encode_memory, and then with the compressed data (because it might have increased in size, though this is very unlikely). The MOVE check is similar, though there, failure of the first check implies corrupt memory (which is why we're Bassert'ing that condition). Currently, the overflow on GAMESTATE sending happens when switching to a different map.
These are element indices for a while now. Also eliminate some dead code afterwards.
r2727 made old savegames incompatible, as an array with MAXVOLUMES*MAXLEVELS is saved in Gv_WriteSave().