What changed in EDuke32, build by build

Also, add convenience wrapper script findmaps.sh for quickly searching for sprites/walls/sectors satisfying a certain condition in all map files under a given directory.

Requested auto-correction will place such sprites at their sector's first point.

Hendricks found a bug caused by that commit, so this one enables exprimentation with setbrightness() bit 1 behavior.

EDuke32 will exit afterwards.

See the comment in source/osdcmds.c for instructions on its usage.

This makes the splitscreen mod not have a ridiculous view distortion. Such scenes will have no correction for non-square pixels, though.

Specifically, use the elevator's own ceiling z height instead of searching nextsectors with nextsectorneighborz(). This makes maps like L9.map (Spaceport from N64) or DEMOUNT.MAP work. [Note well: work at all, since if it happened to work before, that was pure coincidence.]

Have fun researching Duke3D's hardcoded weirdness!!!

- duke3d.h: comment the timing marcos a bit more - factor out smoothratio calculation - (TICRATE/TICSPERFRAME) --> REALGAMETICSPERSEC

Also, correct some comments made in the demo source made earlier. Oops.

This currently says that MP saving/loading isn't supported, but doesn't really work correctly. Also, properly bound-check the immediate argument to CON's 'save' command and one more ... -> G_HandleAsync().

... and use it in three places. In two of these uses, 1) CON {read,write}arrayfromfile and 2) G_SavePlayer, display an error message if the file name such generated is too long. In the CON commands of 1), also error out if the file couldn't be opened.

This trims four 4k pages of code from the release EDuke32 build and one page from Mapster32.

When this happens, parallaxmodes other than 0 will be unavailable and silently draw as parallaxmode 0. This usually happens with extremely wide resolutions.

We're pulling stuff from math.h even in non-GL builds right now, so adding libc's sin() and atan() doesn't seem like a big deal. In the unlikely event that their accuracy is so bad that the calculated tables don't match the original ones, a warning is issued on little-endian platforms.

Playing around with Coccinelle's semantic patches... be prepared for more.

Found by http://coccinelle.lip6.fr/rules/notnull.cocci

Well, this never worked anyway, but invoking demons flying out of your nose is never a good idea.

The spawn-time SE 17 setup uses nextsectorneighborz() which can fail (return -1) on some circumstances and would cause an OOB sector[] access.

This is mostly for debugging, since currently, Mapster32 restores sprites not in the same order as the original sprite index order. Also, expose this option from map2text.lua and mapdiff.sh.

For example, if the first one is underwater.

Basically, base palettes with lower indices trump higher ones. For example, when one player is underwater and the other above, the normal palette takes precedence.

Currently, the only kinds of tint that can be applied simultaneously are one "palfrom" per player, plus one loogie tint per player. Each palfrom still overrides the preceding one. However, this is not a big problem IMO since palfroms decrease at the same rate (loogie tint decreases at half the speed). This change is especially good for the splitscreen mod, since now the tints of the two players won't compete with each other. See the comment in the source for some properties of the blending formula.

Noted by Nukey. See Duke3D 1.5 GAME.C line 4220.

Reverved quotes are ones like "Killed by xxx". Since they're only shown for the first player for now, printing them in the upper part makes more sense (in above/below split, the first player is above).

To enable it, the HUD-less (maximized) screen size must be selected.

I checked all direct and transitive uses of that function and am fairly confident that it is never used.

ROTATESPRITE_MAX is moved to build.h and all orientation bits from CON commands using rotatesprite are ANDed with (ROTATESPRITE_MAX-1). Some of the functions use ROTATESPRITE_MAX for different internal purposes, which will not be exposed to CON now (a good thing). Also, dorotspr_handle_bit2 is made clearer.

The black translucent background underneath the user map list will now be drawn with a shade 32 tile 0 instead of tile BLANK, since I've seen the latter being replaced in some mod. Also, it will look the same regardless of screen aspect.

This also fixes the OSD with aspects < 4/3. I broke that, too.

It seems like I broke the blitty/patchy way of drawing it with one of the last commits.

Classic HUD now has correct aspect in widescreen modes, so with the full status bar, there may be patches of free room left to the left and right.

setaspect(), which is called by setaspect_new, already uses the *dimen variables, so it's the same thing done twice. Now, a change from the original full status bar to the original mini status bar keeps the horizontal FOV again and only bumps the view a little higher, as with the classic aspect determination.

Compare with revision 2584.

This means that classic and the GL modes now look the same as far as e.g. hud_bgstretch or HUD weapons are concerned.

That is, use the view boundries instead of the whole screen.

See the source for why this hack is ugly.

This makes the code rather more readable in some places. Unlike the two preceding commits, this one is actually purely textual replacement.

Functions affected are G_Move* in actors.c and A_Shoot in player.c. Here, the p variable had function scope, now it's redeclared in shorter blocks. I'm still relatively sure that no observable behavior was changed, though not as sure as in part 1. Also, some dead assignments and the like are eliminated.

The p variable (sometimes named differently) has short scope in all cases, so I'm almost sure that the replacements amount to an identity transformation.

... against invalid weapon indices and arguments accessed from arrays/structs.