SVN handles and Git names are merged into one person.
Revert the changes from JFSW commit 7d0deafe81b0ffa30d77cfe242e454f8b4487a1f
related to the definitions of RANDOM_NEG in bunny.cpp, ripper.cpp and ripper2.cpp. Do so in a way that isn't re-introducing compiler warnings. This partially fixes compatibility with demos made for SW 1.2. Additionally, replace the 3 separate definitions of RANDOM_NEG with a common one within game.h.
Fix a few memory access errors related to demo support
Make quitting by closing the window, now done via CON_Quit,
a bit more usable in multiplayer, hiding the engine's console.
Modify MenuLevel and RunLevel by using CON_Quit,
toggling MultiPlayQuitFlag on instead of QuitFlag in multiplayer games if a player tries to close the window. Further update MNU_QuitCustom to use CON_Quit. - In RunLevel, this fixes quit of game for all players. - In MenuLevel, this leads to transmit of PACKET_TYPE_MENU_LEVEL_QUIT. However, the work isn't complete, since the game isn't shut down on the peers' sides, leading to possibly undesired side-effects. Currently known issue: - If the master closes the window, the scores won't be shown for the master. Reason is that waitforeverybody will terminate the app.
Add a few calls to handleevents around key press loops. Also check
quitevent in the game, and further call getpackets within StatScreen.
Make sure StatScreen is called around the same time for
all players after level change. This is done by adding calls to getpackets within the BonusScreen and StatScreen while loops. It is related to a change from the DOS versions of 1997. Basically, dosendpackets immediately sends all packets via the commit driver under DOS, while in the mmulti port in use here, sending might be postponed. This was leading to a problem with the game entering waitforeverybody before showing the stats. In particular, it initially attempted to send a PACKET_TYPE_PLAYER_READY message, which could get postponed in the manner described above. In case it received PACKET_TYPE_PLAYER_READY messages from all other peers before the time arrived for sending pending packets, though, waitforeverybody would return, eventually leading to a call to StatScreen/BonusScreen, without sending the pending message until the user in question continued. Other peers would have to wait for the given player to confirm level change before they could see their own stat screens.
Fix a bug in getpackets, making SW's Master-Slave code usable,
including 3+ players sessions.
Do limit Master/Slave support to 2-players sessions.
Thanks to LittleTijn for testing and inspecting.
Comment out function parameters accessed only in commented out code
Mark function parameters as unused in cases we can't easily change
the functions' signatures (often due to being used as callbacks/hooks)
Remove a bunch of unused function parameters
Handle cases in which the result of an expression
with (possible) side-effects is written to an unused var.
Comment out unused vars, which would become
used if previously commented out code was uncommented (including a few instances of uninitialized var reads).
Remove a ton of unused vars
